Re: [Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old

[Stefan Hajnoczi]

On Thu, Oct 19, 2017 at 04:04:43PM -0400, Aaron Lindsay wrote:
> I get the following error when building on an NFSv3 filesystem:
> 
> % make -j8
>   GEN     aarch64-softmmu/config-devices.mak.tmp
>   GEN     config-host.h
> [snip]
>   GEN     qmp-marshal.c
>   GEN     aarch64-softmmu/config-devices.mak
> cp: preserving permissions for ‘aarch64-softmmu/config-devices.mak.old’: 
> Operation not supported
> make: *** Deleting file `aarch64-softmmu/config-devices.mak'
>   GEN     qapi-types.c
> [snip]
>   CC      scsi/qemu-pr-helper.o
> make: *** No rule to make target `config-all-devices.mak', needed by 
> `subdir-aarch64-softmmu'.  Stop.
> make: *** Waiting for unfinished jobs....
> 
> Ideally you would only build on a filesystem with proper support, but I 
> haven't
> been able to find a reason why preserving exact permissions is important in
> this case.
> 
> Signed-off-by: Aaron Lindsay <address@hidden>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I cannot see a reason why address@hidden must preserve timestamp/mode/ownership
either:

Reviewed-by: Stefan Hajnoczi <address@hidden>