[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9pfs: fix v9fs_mark_fids_unreclaim() return val
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] 9pfs: fix v9fs_mark_fids_unreclaim() return value |
|
Date: |
Fri, 20 Oct 2017 13:48:50 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/20/2017 12:17 PM, Greg Kurz wrote:
> The return value of v9fs_mark_fids_unreclaim() is then propagated to
> pdu_complete(). It should be a negative errno, not -1.
(which happens to be -EPERM on Linux. I like that GNU Hurd picked errno
values far away from 1, so that -1 is distinguishable from a negative
errno on that platform, but I haven't seen evidence of whether anyone
cares if qemu and/or 9pfs compiles on Hurd...)
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> hw/9pfs/9p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature