[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/9] ui: fix crash with sendkey and raw key numbers
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 2/9] ui: fix crash with sendkey and raw key numbers |
Date: |
Mon, 23 Oct 2017 11:19:40 +0200 |
From: "Daniel P. Berrange" <address@hidden>
Previously we enforced that all key events are using QKeyCodes
at time they are sent:
commit af07e5ff02ae6d4258fc5331007811d0b1c4d35a
Author: Daniel P. Berrange <address@hidden>
Date: Fri Sep 29 11:12:00 2017 +0100
ui: convert key events to QKeyCodes immediately
This commit forget to fix the code for the legacy 'sendkey'
command which still accepts key numbers from the user, which
then need converting to QKeyCodes
Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/input-legacy.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
index 6bc3525499..c75aba1549 100644
--- a/ui/input-legacy.c
+++ b/ui/input-legacy.c
@@ -76,6 +76,11 @@ static KeyValue *copy_key_value(KeyValue *src)
{
KeyValue *dst = g_new(KeyValue, 1);
memcpy(dst, src, sizeof(*src));
+ if (dst->type == KEY_VALUE_KIND_NUMBER) {
+ QKeyCode code = qemu_input_key_number_to_qcode(dst->u.number.data);
+ dst->type = KEY_VALUE_KIND_QCODE;
+ dst->u.qcode.data = code;
+ }
return dst;
}
--
2.9.3
- [Qemu-devel] [PULL 0/9] Input 20171023 patches, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 2/9] ui: fix crash with sendkey and raw key numbers,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 9/9] ui: pull in latest keycodemapdb, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 8/9] ui: normalize the 'sysrq' key into the 'print' key, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 6/9] ps2: fix scancodess sent for Pause key in AT set 1, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq), Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 3/9] ui: use correct union field for key number, Gerd Hoffmann, 2017/10/23
- [Qemu-devel] [PULL 1/9] input: use hex in ps2 keycode trace events, Gerd Hoffmann, 2017/10/23
- Re: [Qemu-devel] [PULL 0/9] Input 20171023 patches, Peter Maydell, 2017/10/25