Re: [Qemu-devel] [PATCHv3 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to sun4m.h

[Peter Maydell]

On 14 October 2017 at 19:38, Mark Cave-Ayland
<address@hidden> wrote:
> This enables them to be used outside of lance.c.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> CC: Jason Wang <address@hidden>
> ---
>  hw/net/lance.c           |    9 ---------
>  include/hw/sparc/sun4m.h |   13 +++++++++++++
>  2 files changed, 13 insertions(+), 9 deletions(-)


I would suggest creating a new header file for this device,
include/hw/net/lance.h, rather than stuffing it into the sun4m.h header.
(That kind of header is a bit of a legacy from when we had
ad-hoc header organization, so in general we'd expect things to
go out of it rather than be added to it...)


thanks
-- PMM