[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups
From: |
Artyom Tarasenko |
Subject: |
Re: [Qemu-devel] [PATCHv4 00/13] sun4m: sparc32_dma tidy-ups |
Date: |
Wed, 25 Oct 2017 18:04:46 +0200 |
On Wed, Oct 25, 2017 at 5:59 PM, Mark Cave-Ayland
<address@hidden> wrote:
> This patchset aims to tidy-up the sparc32_dma code by improving the
> modelling of the espdma/ledma devices using both QOM and the memory
> API which didn't exist when the code was first written.
>
> The result is that it is now possible to remove both the iommu_opaque
> and is_ledma workarounds from the code, and the code for wiring up
> the espdma/ledma and respective devices is also a lot more readable.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: Artyom Tarasenko <address@hidden>
>
> v4:
> - Rebase onto git master
> - Update patch 9 to move lance QOM macros/SysBusPCNetState from sun4m.h to
> lance.h as suggested by Peter
> - Add Reviewed-by from Peter for patch 7
>
> v3:
> - Add missing sysbus.h include to esp.h in patch 7
>
> v2:
> - Make esp/lance devices children of espdma/ledma devices respectively
> - Add len parameter to ledma/espdma tracepoints
>
>
> Mark Cave-Ayland (13):
> sparc32_dma: rename SPARC32_DMA type to SPARC32_DMA_DEVICE
> sparc32_dma: split esp and le into separate DMA devices
> sparc32_dma: move type declarations from sparc32_dma.c to
> sparc32_dma.h
> sun4m: move DMA device wiring from sparc32_dma_init() to
> sun4m_hw_init()
> sun4m_iommu: move TYPE_SUN4M_IOMMU declaration to sun4m.h
> sparc32_dma: use object link instead of qdev property to pass IOMMU
> reference
> esp: move TYPE_ESP and SysBusESPState from esp.c to esp.h
> sparc32_dma: make esp device child of espdma device
> lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h
> sparc32_dma: make lance device child of ledma device
> sparc32_dma: introduce new SPARC32_DMA type container object
> sparc32_dma: remove is_ledma hack and replace with memory region
> alias
> sparc32_dma: add len to esp/le DMA memory tracing
>
> hw/dma/sparc32_dma.c | 235
> +++++++++++++++++++++++++++++-----------
> hw/dma/sun4m_iommu.c | 14 ---
> hw/dma/trace-events | 8 +-
> hw/net/lance.c | 11 +-
> hw/scsi/esp.c | 13 ---
> hw/sparc/sun4m.c | 82 ++++++--------
> include/hw/net/lance.h | 41 +++++++
> include/hw/scsi/esp.h | 14 +++
> include/hw/sparc/sparc32_dma.h | 55 ++++++++++
> include/hw/sparc/sun4m.h | 16 +++
> 10 files changed, 336 insertions(+), 153 deletions(-)
> create mode 100644 include/hw/net/lance.h
>
> --
> 1.7.10.4
>
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu