[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 32/39] mips: use object_new() instead of gnew()+objec
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 32/39] mips: use object_new() instead of gnew()+object_initialize() |
Date: |
Thu, 26 Oct 2017 16:03:57 +0200 |
From: Igor Mammedov <address@hidden>
object_initialize() is intended for inplace initialization of
objects, but here it's first allocated with g_new0() and then
initialized with object_initialize(). QEMU already has API
to do this (object_new), so do object creation with suitable
for usecase API.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/mips/boston.c | 3 +--
hw/mips/mips_malta.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index 776ee283e1..e815be6a6c 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -460,7 +460,6 @@ static void boston_mach_init(MachineState *machine)
s = BOSTON(dev);
s->mach = machine;
- s->cps = g_new0(MIPSCPSState, 1);
if (!cpu_supports_cps_smp(cpu_model)) {
error_report("Boston requires CPUs which support CPS");
@@ -469,7 +468,7 @@ static void boston_mach_init(MachineState *machine)
is_64b = cpu_supports_isa(cpu_model, ISA_MIPS64);
- object_initialize(s->cps, sizeof(MIPSCPSState), TYPE_MIPS_CPS);
+ s->cps = MIPS_CPS(object_new(TYPE_MIPS_CPS));
qdev_set_parent_bus(DEVICE(s->cps), sysbus_get_default());
object_property_set_str(OBJECT(s->cps), cpu_model, "cpu-model", &err);
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 2adb9bcf89..b6a58c7f21 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -949,9 +949,8 @@ static void create_cps(MaltaState *s, const char *cpu_model,
qemu_irq *cbus_irq, qemu_irq *i8259_irq)
{
Error *err = NULL;
- s->cps = g_new0(MIPSCPSState, 1);
- object_initialize(s->cps, sizeof(MIPSCPSState), TYPE_MIPS_CPS);
+ s->cps = MIPS_CPS(object_new(TYPE_MIPS_CPS));
qdev_set_parent_bus(DEVICE(s->cps), sysbus_get_default());
object_property_set_str(OBJECT(s->cps), cpu_model, "cpu-model", &err);
--
2.13.6
- [Qemu-devel] [PULL 22/39] xtensa: sim: use generic cpu_model parsing, (continued)
- [Qemu-devel] [PULL 22/39] xtensa: sim: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 23/39] xtensa: lx60/lx200/ml605/kc705: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 24/39] unicore32: cleanup cpu type name composition, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 25/39] unicore32: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 26/39] tricore: cleanup cpu type name composition, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 28/39] sparc: cleanup cpu type name composition, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 27/39] tricore: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 30/39] sparc: sparc: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 29/39] sparc: sun4u/sun4v/niagara: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 31/39] sparc: leon3: use generic cpu_model parsing, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 32/39] mips: use object_new() instead of gnew()+object_initialize(),
Eduardo Habkost <=
- [Qemu-devel] [PULL 33/39] mips: malta/boston: replace cpu_model with cpu_type, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 34/39] mips: fulong2e: replace cpu_model with cpu_type, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 35/39] mips: Magnum/Acer Pica 61: replace cpu_model with cpu_type, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 37/39] mips: r4k: replace cpu_model with cpu_type, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 36/39] mips: mipssim: replace cpu_model with cpu_type, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 38/39] numa: fixup parsed NumaNodeOptions earlier, Eduardo Habkost, 2017/10/26
- [Qemu-devel] [PULL 39/39] x86: Skip check apic_id_limit for Xen, Eduardo Habkost, 2017/10/26
- Re: [Qemu-devel] [PULL 00/39] x86/cpu/numa queue, 2017-10-26, Peter Maydell, 2017/10/27