Re: [Qemu-devel] [PATCH v2 2/4] build: don't create temporary files in source dir

[Alexey Kardashevskiy]

On 28/10/17 16:25, Eric Blake wrote:
> On 10/27/2017 03:14 PM, Daniel P. Berrange wrote:
>> There are cases where users do VPATH builds with the source directory being 
>> on
>> a read-only volume. In such a case they have to manually run the command
>> 'git-submodule.sh ...modules...'  manually ahead of time. When checking for
> 
> One of the two "manually" can be removed (either one, and the sentence
> still makes sense)
> 
>> status we should not then write into the source dir.
>>
>> Signed-off-by: Daniel P. Berrange <address@hidden>
>> ---
>>  scripts/git-submodule.sh | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
>> index c66567d409..586ff32293 100755
>> --- a/scripts/git-submodule.sh
>> +++ b/scripts/git-submodule.sh
>> @@ -31,10 +31,10 @@ fi
>>  case "$command" in
>>  status)
>>      test -f "$substat" || exit 1
>> -    trap "rm -f ${substat}.tmp" EXIT
>> -    $GIT submodule status $modules > "${substat}.tmp"
>> -    test $? -ne 0 && error "failed to query git submodule status"
>> -    diff "${substat}" "${substat}.tmp" >/dev/null
>> +    substat_tmp=$(mktemp)
> 
> Is mktemp portable enough?  Hopefully so.

It could also be some fixed file name in the build directory.


-- 
Alexey

signature.asc
Description: OpenPGP digital signature