[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/3] hw/arm: Mark the "fsl, imx6" device with user_c
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PATCH 1/3] hw/arm: Mark the "fsl, imx6" device with user_creatable = false |
Date: |
Wed, 1 Nov 2017 07:58:55 +0100 |
This device causes QEMU to abort if the user tries to instantiate it:
$ qemu-system-aarch64 -M sabrelite -smp 1,maxcpus=2 -device fsl,,imx6
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
qemu-system-aarch64: -device fsl,,imx6: Device 'serial0' is in use
Aborted (core dumped)
The device uses serial_hds[] directly in its realize function, so it
can not be instantiated again by the user.
Signed-off-by: Thomas Huth <address@hidden>
---
hw/arm/fsl-imx6.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
index 26fd214..59ef33e 100644
--- a/hw/arm/fsl-imx6.c
+++ b/hw/arm/fsl-imx6.c
@@ -440,8 +440,9 @@ static void fsl_imx6_class_init(ObjectClass *oc, void *data)
DeviceClass *dc = DEVICE_CLASS(oc);
dc->realize = fsl_imx6_realize;
-
dc->desc = "i.MX6 SOC";
+ /* Reason: Uses serial_hds[] in the realize() function */
+ dc->user_creatable = false;
}
static const TypeInfo fsl_imx6_type_info = {
--
1.8.3.1
- [Qemu-devel] [PATCH 0/3] hw/arm: Mark the "fsl, imx" devices with user_creatable = false, Thomas Huth, 2017/11/01
- [Qemu-devel] [PATCH 2/3] hw/arm: Mark the "fsl, imx25" device with user_creatable = false, Thomas Huth, 2017/11/01
- [Qemu-devel] [PATCH 3/3] hw/arm: Mark the "fsl, imx31" device with user_creatable = false, Thomas Huth, 2017/11/01
- [Qemu-devel] [PATCH 1/3] hw/arm: Mark the "fsl, imx6" device with user_creatable = false,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH 0/3] hw/arm: Mark the "fsl, imx" devices with user_creatable = false, Peter Maydell, 2017/11/02