[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse

From: Pradeep Jagadeesh
Subject: Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code
Date: Thu, 2 Nov 2017 13:03:54 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 11/2/2017 12:00 PM, Alberto Garcia wrote:
On Thu 02 Nov 2017 11:55:26 AM CET, Pradeep Jagadeesh wrote:

-    if (arg->has_iops_rd_max_length) {
-        cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length;
-    }
-    if (arg->has_iops_wr_max_length) {
-        cfg.buckets[THROTTLE_OPS_WRITE].burst_length = arg->iops_wr_max_length;
-    }
-    if (arg->has_iops_size) {
-        cfg.op_size = arg->iops_size;
-    }

The old code takes an empty ThrottleConfig, and initializes it using the
values from a BlockIOThrottle structure...

+    tlimit = qapi_BlockIOThrottle_base(arg);
+    throttle_config_to_limits(&cfg, tlimit);

...but the new code does the exact opposite (?).

Its a mistake of a call. It should be throttle_limits_to_config()
I will change it.

Thanks! It would be nice if the series had a few tests to verify that
this all is working as expected :-)

Sure!. Next time on!.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]