Re: [Qemu-devel] [RFC PATCH 08/26] replay: make safe vmstop at record/replay

[Paolo Bonzini]

On 02/11/2017 13:04, Pavel Dovgalyuk wrote:
>> From: Paolo Bonzini [mailto:address@hidden
>>>>> diff --git a/migration/savevm.c b/migration/savevm.c
>>>>> index 20cebe1..41a13c0 100644
>>>>> --- a/migration/savevm.c
>>>>> +++ b/migration/savevm.c
>>>>> @@ -2143,8 +2143,8 @@ int save_snapshot(const char *name, Error **errp)
>>>>>      AioContext *aio_context;
>>>>>
>>>>>      if (!replay_can_snapshot()) {
>>>>> -        monitor_printf(mon, "Record/replay does not allow making 
>>>>> snapshot "
>>>>> -                        "right now. Try once more later.\n");
>>>>> +        error_report("Record/replay does not allow making snapshot "
>>>>> +                     "right now. Try once more later.\n");
>>>>
>>>> Why this change?
>>>
>>> Kind of a mess in changes.
>>> It should be in patch 06 which introduce these lines.
>>> I'll fix it in the next version.
>>
>> No problem.  Remember to delete the \n too since otherwise patchew
>> complains.
> 
> Is this ok for the line over 80 symbols here?

Patchew (and checkpatch) are complaining about the \n in the string,
i.e. "later.\n" -> "later.".

Thanks,

Paolo