[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

From: Programmingkid
Subject: Re: [Qemu-devel] [PATCH v2 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g
Date: Thu, 2 Nov 2017 11:20:42 -0400

> On Nov 2, 2017, at 5:10 AM, Peter Maydell <address@hidden> wrote:
> On 5 October 2017 at 15:55, John Arbuckle <address@hidden> wrote:
>> Currently the cocoa user interface relys on the user pushing control-alt to 
>> ungrab the mouse. This is patch changes the key combination to control-alt-g 
>> to be in line with the GTK user interface.
>> signed-off-by: John Arbuckle <address@hidden>
>> ---
>> +
>> +                    // release the mouse grab
>> +                    case Q_KEY_CODE_G:
>> +                        [self ungrabMouse];
>> +                        break;
>>                 }
> Testing this I have found that it makes the grab key be
> "ctrl+alt+ the key labelled 'g'", even if in the
> OSX host keyboard mapping that key doesn't produce the
> letter 'g'. This is in contrast to for instance the menu
> accelerators which honour the host keyboard layout, and
> it's also not what the GTK UI does. So I think we need
> to fix that.

I just realized that the cocoa interface does not consider the keyboard layout. 
Switching from QWERTY to DVORK I still see the same keys outputting the same 
characters in OpenBIOS. This is a separate patch but sometime to take note. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]