[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: vmcoreinfo in error_

From: Daniel Henrique Barboza
Subject: Re: [Qemu-devel] [PATCH] scripts/device-crash-test: vmcoreinfo in error_whitelist for ppc64
Date: Fri, 3 Nov 2017 11:16:10 -0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 11/03/2017 10:52 AM, Thomas Huth wrote:
On 03.11.2017 13:30, Marc-André Lureau wrote:
Hi Thomas

On Fri, Nov 3, 2017 at 1:01 PM, Thomas Huth <address@hidden> wrote:
On 03.11.2017 12:49, Marc-André Lureau wrote:
Hi Daniel

On Fri, Oct 27, 2017 at 8:17 PM, Daniel Henrique Barboza
<address@hidden> wrote:
The device vmcoreinfo depends on the fw_cfg device to work, a device
that isn't available in most ppc64 machines. This makes device-crash-test
spams the following error when running with qemu-system-ppc64:

"INFO: log: qemu-system-ppc64: -device vmcoreinfo: vmcoreinfo device
requires fw_cfg with DMA"
It's not only about ppc64 - this problem exists also on most other
targets, e.g.:

$ m68k-softmmu/qemu-system-m68k -M none -device vmcoreinfo
qemu-system-m68k: -device vmcoreinfo: vmcoreinfo device requires fw_cfg
with DMA

So for the device-crash-test script, I think it would make more sense to
add a generic, machine-independent entry for this.

Additionally, I think it's also a bad idea to blindly add this
vmcoreinfo device to all targets! We should only add it to the targets
that actually feature the fw_cfg device with DMA, so we need a proper
CONFIG_xxx switch for this. Marc-André or Daniel, do you have time to
work on such a patch? Otherwise, I can have a look at this, too.
Ah the DMA interface is only available on x86 & arm virt apparently. I
thought it would be more widely available.

I can add a CONFIG_FW_CFG_DMA, set by x86)64-softmuu & arm-softmmu,
and make vmcoreinfo depend on it. Would that be good enough?

There are some ppc64-softmmu machines that have support for the -fw_cfg
device, although I am not sure if in those cases the device has a DMA

-machine 40p
-machine g3beige
-machine mac99

Just a FYI.



Yes, that sounds good to me!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]