Re: [Qemu-devel] [PATCH qemu] isa-bus: Replace assert() about DMA with error report

[Peter Maydell]

On 26 October 2017 at 09:00, Alexey Kardashevskiy <address@hidden> wrote:
> Running "qemu-system-ppc64 -machine prep -device i82374" creates an ISA
> bus with two i82374 DMA controllers - one is implicit from ppc_prep_init(),
> the other one is from "-device i82374". QEMU asserts but it is not
> immediately clear why.
>
> This adds an error message to explain the failure.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>

Does it ever make sense for the user to try to create this
device on the command line? If not, maybe we should set
it to dc->user_creatable = false; ?

If it can be usefully user-created, then rather than being
a fatal error in this function the error should be passed
back up so that we can fail the 'realize' method of the device.

thanks
-- PMM