Re: [Qemu-devel] [PATCH] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets

[Daniel Henrique Barboza]

On 11/06/2017 09:53 AM, Marc-André Lureau wrote:
> vmcoreinfo is built for all targets. However, it requires fw_cfg with
> DMA operations support (write operation). Restrict vmcoreinfo exposure
> to architectures that are supporting FW_CFG_DMA, that is arm-virt and
> x86 only atm.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---

Reviewed-by: Daniel Henrique Barboza <address@hidden>
Tested-by: Daniel Henrique Barboza <address@hidden>

>   default-configs/arm-softmmu.mak    | 2 ++
>   default-configs/i386-softmmu.mak   | 1 +
>   default-configs/x86_64-softmmu.mak | 1 +
>   hw/misc/Makefile.objs              | 2 +-
>   4 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 5059d134c8..d37edc4312 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -130,3 +130,5 @@ CONFIG_SMBIOS=y
>   CONFIG_ASPEED_SOC=y
>   CONFIG_GPIO_KEY=y
>   CONFIG_MSF2=y
> +
> +CONFIG_FW_CFG_DMA=y
> diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
> index a685c439e7..95ac4b464a 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>   CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>   CONFIG_PXB=y
>   CONFIG_ACPI_VMGENID=y
> +CONFIG_FW_CFG_DMA=y
> diff --git a/default-configs/x86_64-softmmu.mak 
> b/default-configs/x86_64-softmmu.mak
> index ea69e8289e..0221236825 100644
> --- a/default-configs/x86_64-softmmu.mak
> +++ b/default-configs/x86_64-softmmu.mak
> @@ -60,3 +60,4 @@ CONFIG_SMBIOS=y
>   CONFIG_HYPERV_TESTDEV=$(CONFIG_KVM)
>   CONFIG_PXB=y
>   CONFIG_ACPI_VMGENID=y
> +CONFIG_FW_CFG_DMA=y
> diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs
> index 19202d90cf..10c88a84b4 100644
> --- a/hw/misc/Makefile.objs
> +++ b/hw/misc/Makefile.objs
> @@ -9,7 +9,7 @@ common-obj-$(CONFIG_PCI_TESTDEV) += pci-testdev.o
>   common-obj-$(CONFIG_EDU) += edu.o
>   
>   common-obj-y += unimp.o
> -common-obj-y += vmcoreinfo.o
> +common-obj-$(CONFIG_FW_CFG_DMA) += vmcoreinfo.o
>   
>   obj-$(CONFIG_VMPORT) += vmport.o
>