[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

From: Jens Freimann
Subject: Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue
Date: Mon, 6 Nov 2017 14:53:59 +0100
User-agent: NeoMutt/20170914 (1.9.0)

On Mon, Nov 06, 2017 at 01:33:49PM +0000, Darren Kenny wrote:
Hi Jan,

On Mon, Nov 06, 2017 at 02:28:05PM +0100, Jens Freimann wrote:
This fixes coverity issue CID1005339.

Make sure that saddr is not used uninitialized if the
mcast parameter is NULL.

Cc: address@hidden
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
net/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index e6b471c63d..51eaea67a0 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -332,7 +332,7 @@ static NetSocketState 
*net_socket_fd_init_dgram(NetClientState *peer,
                                               const char *mcast,
                                               Error **errp)
-    struct sockaddr_in saddr;
+    struct sockaddr_in saddr = { 0 };

Based on:


It would appear that the use of {} to initialize the struct is
preferred over {0}.

Thanks for the hint Darren. I'll change it in the next version (or get
rid of the initalization completely).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]