[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 15/18] Fix unavailable fields in stbuf under Win

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 15/18] Fix unavailable fields in stbuf under Windows.
Date: Mon, 6 Nov 2017 16:25:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 06/11/2017 16:23, Michael Fritscher wrote:
>> Likewise, I think it should be struct FileOperations's lstat member that
>> uses struct V9fsStatDotl instead of struct stat.  Then
>> stat_to_v9stat_dotl would be hidden inside 9p-local.c (and 9p-local.c
>> isn't going to be used by Windows at all, so this patch disappears).
>> Paolo
> At first: thanks for reviewing!
> Yes, the main question for me at this stage is:
>   * use the 9p-local.c and try workaround the limitations (e.g. lack of
> the *at functions) by creating stubs)
>   * make a own 9p-local-windows.c and use ntdlls functions, which is a bit
> more ugly.
> I decribed these options a moment ago in the other mail in more detail.
> For me both way are fine.

Given the limitations of the Windows standard C library, I think the
latter makes more sense.  It could be kernel32 or ntdll, that doesn't
really matter (though ntdll is a better match for 9p and I think it's
worth it); but msvcrt is probably just as ugly as ntdll and even more
limited than kernel32.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]