[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tpm: Don't call tpm_cleanup unless CONFIG_TPM.

From: Stefan Berger
Subject: Re: [Qemu-devel] [PATCH] tpm: Don't call tpm_cleanup unless CONFIG_TPM.
Date: Mon, 6 Nov 2017 12:52:35 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 11/06/2017 12:49 PM, Michael Tokarev wrote:
19.10.2017 10:50, Richard W.M. Jones wrote:
When compiling with --disable-tpm:

   ../vl.o: In function `main':
   /home/rjones/d/qemu/vl.c:4908: undefined reference to `tpm_cleanup'

This appears to have been introduced in commit c37cacabf228
("tpm: Move tpm_cleanup() to right place").

index 0723835bbf..dbfd06d4bc 100644
--- a/vl.c
+++ b/vl.c
@@ -4905,7 +4905,9 @@ int main(int argc, char **argv, char **envp)
/* vhost-user must be cleaned up before chardevs. */
+#ifdef CONFIG_TPM
Maybe we can define it to an empty macro (or inline function) in
the header file instead?

It's solved with a stub in stubs/tpm.c.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]