[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 22/28] tpm-emulator: add a FIXME comment about bl
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v2 22/28] tpm-emulator: add a FIXME comment about blocking cancel |
Date: |
Mon, 6 Nov 2017 19:39:19 +0100 |
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
---
hw/tpm/tpm_emulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index ff5fcbae03..b77c0238c7 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -328,6 +328,7 @@ static void tpm_emulator_cancel_cmd(TPMBackend *tb)
return;
}
+ /* FIXME: make the function non-blocking, or it may block a VCPU */
if (tpm_emulator_ctrlcmd(&tpm_emu->ctrl_chr, CMD_CANCEL_TPM_CMD, &res, 0,
sizeof(res)) < 0) {
error_report("tpm-emulator: Could not cancel command: %s",
--
2.15.0.rc0.40.gaefcc5f6f
- [Qemu-devel] [PATCH v2 10/28] tpm-be: update optional function pointers, (continued)
- [Qemu-devel] [PATCH v2 10/28] tpm-be: update optional function pointers, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 13/28] tpm-passthrough: make it safer to destroy after creation, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 14/28] tpm-passthrough: simplify create(), Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 15/28] tpm-passthrough: workaround a possible race, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 16/28] tpm-tis: simplify header inclusion, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 17/28] tpm: rename qemu_find_tpm() -> qemu_find_tpm_be(), Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 18/28] tpm: lookup the the TPM interface instead of TIS device, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 19/28] tpm: add TPM interface to lookup TPM version, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 20/28] tpm: add tpm_cmd_get_size() to tpm_util, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 21/28] acpi: change TPM TIS data conditions, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 22/28] tpm-emulator: add a FIXME comment about blocking cancel,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v2 23/28] tpm-tis: remove redundant 'tpm_tis:' in error messages, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 24/28] tpm-tis: check that at most one TPM device exists, Marc-André Lureau, 2017/11/06
- [Qemu-devel] [PATCH v2 25/28] tpm-emulator: protect concurrent ctrl_chr access, Marc-André Lureau, 2017/11/06
[Qemu-devel] [PATCH v2 26/28] qdev: add DEFINE_PROP_TPMBE, Marc-André Lureau, 2017/11/06