qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 3/4] block/parallels: add migration blocker


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v3 3/4] block/parallels: add migration blocker
Date: Tue, 7 Nov 2017 10:04:17 +0000
User-agent: Mutt/1.9.1 (2017-09-22)

On Mon, Nov 06, 2017 at 09:31:21PM -0500, Jeff Cody wrote:
> @@ -720,6 +722,16 @@ static int parallels_open(BlockDriverState *bs, QDict 
> *options, int flags,
>      s->bat_dirty_bmap =
>          bitmap_new(DIV_ROUND_UP(s->header_size, s->bat_dirty_block));
>  
> +    /* Disable migration until bdrv_invalidate_cache method is added */
> +    error_setg(&s->migration_blocker, "The Parallels format used by node 
> '%s' "
> +               "does not support live migration",
> +               bdrv_get_device_or_node_name(bs));
> +    ret = migrate_add_blocker(s->migration_blocker, &local_err);
> +    if (local_err) {
> +        error_propagate(errp, local_err);
> +        error_free(s->migration_blocker);
> +        goto fail;
> +    }

Please call migrate_del_blocker() and error_free() in .bdrv_close().

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]