[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/1] Makefile: Capstone: Add support for cros

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 1/1] Makefile: Capstone: Add support for cross compile ranlib
Date: Thu, 9 Nov 2017 11:09:32 +0000

On 8 November 2017 at 15:10, Alistair Francis
<address@hidden> wrote:
> When cross compiling QEMU for Windows we need to specify the cross
> version of ranlib to avoid build errors when building capstone. This
> patch ensures we use the same cross prefix on ranlib as other toolchain
> components.
> This patch fixes this build error when building on RHEL (or Fedora) with
> MinGW:
> /scratch/jenkins_tmp/workspace/QEMU-BuildAll/label/ssw_rhel7/target/windows/build-windows/capstone/capstone.lib:
> error adding symbols: Archive has no index; run ranlib to add one
> collect2: error: ld returned 1 exit status
> make: *** [qemu-io.exe] Error 1
> Signed-off-by: Alistair Francis <address@hidden>
> Suggested-by: Peter Maydell <address@hidden>
> Reviewed-by: Philippe Mathieu-Daud <address@hidden>
> Tested-by: Philippe Mathieu-Daud <address@hidden>

Something in your patch handling workflow seems to be
breaking non-ASCII characters, and it has dropped the
last character in Philippe's surname. It would be good
if you could look into fixing this -- we have quite a
few contributors whose names are not representable
purely in ASCII.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]