Re: [Qemu-devel] [PATCH V4] hw/pcie-pci-bridge: restrict to X86 and ARM

[Marcel Apfelbaum]

On 09/11/2017 16:29, Philippe Mathieu-Daudé wrote:
> Hi Marcel,
>
> On 11/09/2017 11:10 AM, Marcel Apfelbaum wrote:
> > On 09/11/2017 16:03, Thomas Huth wrote:
> > > On 09.11.2017 14:04, address@hidden wrote:
> > > > Hi,
> > > >
> > > > This series failed automatic build test. Please find the testing
> > > > commands and
> > > > their output below. If you have docker installed, you can probably
> > > > reproduce it
> > > > locally.
> > > [...]
> > > >     CC      aarch64-softmmu/hw/scsi/virtio-scsi.o
> > > >     CC      aarch64-softmmu/hw/scsi/virtio-scsi-dataplane.o
> > > > make[1]: *** No rule to make target
> > > > `../hw/pci-bridge/pcie_pci_bridge.o', needed by
> > > > `qemu-system-x86_64'.  Stop.
> > > > make[1]: *** Waiting for unfinished jobs....
> > > >     CC      aarch64-softmmu/hw/scsi/vhost-scsi-common.o
> > > >     CC      aarch64-softmmu/hw/scsi/vhost-scsi.o
> > > >     CC      aarch64-softmmu/hw/scsi/vhost-user-scsi.o
> > > >     CC      aarch64-softmmu/hw/sd/omap_mmc.o
> > > >     CC      aarch64-softmmu/hw/sd/pxa2xx_mmci.o
> > > >     CC      aarch64-softmmu/hw/sd/bcm2835_sdhost.o
> > > > make: *** [subdir-x86_64-softmmu] Error 2
> > > > make: *** Waiting for unfinished jobs....
> > > >     CC      aarch64-softmmu/hw/ssi/omap_spi.o
> > > >     CC      aarch64-softmmu/hw/ssi/imx_spi.o
> > > >     CC      aarch64-softmmu/hw/timer/exynos4210_mct.o
> > > >     CC      aarch64-softmmu/hw/timer/exynos4210_pwm.o
> > > [...]
> > > >     CC      aarch64-softmmu/hw/timer/exynos4210_rtc.o
> > > >     CC      aarch64-softmmu/target/arm/translate-a64.o
> > > > make[1]: *** No rule to make target
> > > > `../hw/pci-bridge/pcie_pci_bridge.o', needed by
> > > > `qemu-system-aarch64'.  Stop.
> > > > make[1]: *** Waiting for unfinished
> > > > jobs..../tmp/qemu-test/src/target/arm/translate-a64.c: In function
> > > > 'handle_shri_with_rndacc':
> > >
> > > Hmm, looks like this was not working as expected?
> >
> > In my workstation works just fine (clean and compiled all archs),
> > I sent a mail to Fam.
>
> Applying your patch on v2.11.0-rc0 I also get this:
>
> make[1]: *** No rule to make target
> '../hw/pci-bridge/pcie_pci_bridge.o', needed by 'qemu-system-aarch64'.
> Stop.
> Makefile:383: recipe for target 'subdir-aarch64-softmmu' failed
> make: *** [subdir-aarch64-softmmu] Error 2
>
> $ fgrep CONFIG_PCIE config-all-devices.mak
> CONFIG_PCIE_PCI_BRIDGE:=$(findstring
> y,$(CONFIG_PCIE_PCI_BRIDGE)$(CONFIG_PCIE_PORT))
> CONFIG_PCIE_PORT:=$(findstring y,$(CONFIG_PCIE_PORT)y)
>
> $ make subdir-aarch64-softmmu --debug=v 2>/dev/null | fgrep -i
> pcie_pci_bridge
> Reading makefile '../hw/pci-bridge/pcie_pci_bridge.d' (search path)
> (don't care) (no ~ expansion)...
>      Considering target file '../hw/pci-bridge/pcie_pci_bridge.o'.
>       File '../hw/pci-bridge/pcie_pci_bridge.o' does not exist.
>       Finished prerequisites of target file
> '../hw/pci-bridge/pcie_pci_bridge.o'.
>      Must remake target '../hw/pci-bridge/pcie_pci_bridge.o'.

Hi Philippe,
Thanks for trying it! I succeeded to reproduce with an out of tree build.
For some reason the make system doesn't work as I would want to.

I'll resend a working version,
Thanks,
Marcel