qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE


From: Yi Min Zhao
Subject: Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE
Date: Fri, 10 Nov 2017 17:22:26 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0



在 2017/11/10 上午12:50, Cornelia Huck 写道:
On Tue,  7 Nov 2017 18:24:34 +0100
Pierre Morel <address@hidden> wrote:

Enhance the fault detection, correction of the fault reporting.

Signed-off-by: Pierre Morel <address@hidden>
Reviewed-by: Yi Min Zhao <address@hidden>
---
  hw/s390x/s390-pci-inst.c | 41 ++++++++++++++++++++++++-----------------
  1 file changed, 24 insertions(+), 17 deletions(-)

diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 8fcb02d..4a2f996 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -469,6 +469,12 @@ int pcistg_service_call(S390CPU *cpu, uint8_t r1, uint8_t 
r2)
      pcias = (env->regs[r2] >> 16) & 0xf;
      len = env->regs[r2] & 0xf;
      offset = env->regs[r2 + 1];
+    data = env->regs[r1];
+
+    if (!(fh & FH_MASK_ENABLE)) {
This covers the reserved/standby/disabled states, right?
yes

[...]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]