[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfu

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [Qemu devel PATCH] MAINTAINERS: Add entries for Smartfusion2
Date: Fri, 10 Nov 2017 09:11:17 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

Hi Sundeep, Peter.

>     On 11/09/2017 08:55 PM, Peter Maydell wrote:
>     > On 9 November 2017 at 21:46, Philippe Mathieu-Daudé <address@hidden 
> <mailto:address@hidden>> wrote:
>     >> Hi Subbaraya,
>     >>
>     >> On 11/09/2017 09:02 AM, Subbaraya Sundeep wrote:
>     >>> add voluntarily myself as maintainer for Smartfusion2
>     >>
>     >> You need to share your GnuPG key signed, I couldn't find it using
>     >> http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep
>     <http://pgp.mit.edu/pks/lookup?search=Subbaraya+Sundeep>
>     >>
>     >> from https://wiki.qemu.org/Contribute/SubmitAPullRequest
>     <https://wiki.qemu.org/Contribute/SubmitAPullRequest> :
>     >
>     > I don't in general expect to take pull requests from
>     > everybody listed as a maintainer in the MAINTAINERS file.
>     > That just means "I'm going to be reviewing and should
>     > be cc'd on patches". Pull requests are sent by people
>     > who are maintainers for a subsystem. Rule of thumb:
>     > unless somebody asks you to send a pull request, you
>     > don't need to do it.
>     Ok, please apologize my misunderstanding. I still think the M: entry

Peter: Oops :) read "I apologize"

>     stand for 'Maintainer' instead of 'Mail', and still don't understand the
>     difference with a "Designated reviewer" (R: entry):
>             M: Mail patches to: FullName <address@hidden>
>             R: Designated reviewer: FullName <address@hidden>
>                These reviewers should be CCed on patches.
>     "Designated reviewer" seems to duplicate the M: entry and is therefore
>     confusing. Can we simply remove it instead?
>     When introduced in fdf6fab4df4 the explanation was:
>     --
>     Some people are not content with the amount of mail they get, and would
>     like to be CCed on patches for areas they do not maintain.  Let them
>     satisfy their own appetite for qemu-devel messages.
>     Seriously: the purpose here is a bit different from the Linux kernel.
>     While Linux uses "R" to designate non-maintainers for reviewing patches
>     in a given area, in QEMU I would also like to use "R" so that people can
>     delegate sending pull requests while keeping some degree of oversight.
>     --
> Do you want me to remove M: and put only R: ?

No, it seems you are correct and I was wrong :)

If you agree changing the first section title to "SmartFusion2" and
eventually the second to "Emcraft M2S-FG484":

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]