[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSI
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again |
Date: |
Tue, 14 Nov 2017 14:35:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 14/11/2017 09:17, Pavel Dovgalyuk wrote:
> From: Alex Bennée <address@hidden>
>
> This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the
> replay file format. Also add a comment about this to
> replay-internal.h.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Reviewed-off-by: Pavel Dovgalyuk <address@hidden>
>
> ---
> replay/replay-internal.h | 2 +-
> replay/replay.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/replay/replay-internal.h b/replay/replay-internal.h
> index be96d7e..8e4c701 100644
> --- a/replay/replay-internal.h
> +++ b/replay/replay-internal.h
> @@ -12,7 +12,7 @@
> *
> */
>
> -
> +/* Any changes to order/number of events will need to bump REPLAY_VERSION */
> enum ReplayEvents {
> /* for instruction event */
> EVENT_INSTRUCTION,
> diff --git a/replay/replay.c b/replay/replay.c
> index ff58a5a..4f24498 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -22,7 +22,7 @@
>
> /* Current version of the replay mechanism.
> Increase it when file format changes. */
> -#define REPLAY_VERSION 0xe02006
> +#define REPLAY_VERSION 0xe02007
> /* Size of replay log header */
> #define HEADER_SIZE (sizeof(uint32_t) + sizeof(uint64_t))
>
>
Acked-by: Paolo Bonzini <address@hidden>
- Re: [Qemu-devel] [RFC PATCH v2 07/26] replay: added replay log format description, (continued)
- [Qemu-devel] [RFC PATCH v2 08/26] replay: make safe vmstop at record/replay, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 09/26] replay: save prior value of the host clock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 10/26] icount: fixed saving/restoring of icount warp timers, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 11/26] target/arm/arm-powertctl: drop BQL assertions, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 12/26] cpus: push BQL lock to qemu_*_wait_io_event, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 13/26] cpus: only take BQL for sleeping threads, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again, Pavel Dovgalyuk, 2017/11/14
- Re: [Qemu-devel] [RFC PATCH v2 14/26] replay/replay.c: bump REPLAY_VERSION again,
Paolo Bonzini <=
- [Qemu-devel] [RFC PATCH v2 15/26] replay/replay-internal.c: track holding of replay_lock, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 16/26] replay: make locking visible outside replay code, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 17/26] replay: push replay_mutex_lock up the call tree, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 18/26] cpu-exec: don't overwrite exception_index, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 19/26] cpu-exec: reset exit flag before calling cpu_exec_nocache, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 20/26] replay: don't destroy mutex at exit, Pavel Dovgalyuk, 2017/11/14
- [Qemu-devel] [RFC PATCH v2 21/26] replay: check return values of fwrite, Pavel Dovgalyuk, 2017/11/14