[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a

From: Jason Wang
Subject: Re: [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a
Date: Wed, 15 Nov 2017 19:22:32 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 2017年11月15日 14:43, Stefan Weil wrote:

I currently think that this patch is wrong and should be reverted.

It fixes a certain use case by hacking the PCI device id, but does
not model the way how that device id is set on the real hardware

As far as I know, all i82559 have a default PCI device id of 0x1229.
It can be changed by the EEPROM configuration, but not all network
cards do have an EEPROM.

See for example this URL for more information:

The correct solution is modeling the EEPROM and allowing QEMU
users to provide an EEPROM‌ file.

Yes and unless there's new version of sepc that has different ID, I tend to revert this.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]