[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1] ps2: check PS2Queue pointers in post_load ro

From: P J P
Subject: Re: [Qemu-devel] [PATCH v1] ps2: check PS2Queue pointers in post_load routine
Date: Thu, 16 Nov 2017 15:49:16 +0530 (IST)

+-- On Thu, 16 Nov 2017, Paolo Bonzini wrote --+
| you don't need to change the invalid values to sane ones.  Instead, make
| ps2_common_post_load return an int (just like the .post_load member of
| VMStateDescription).  You can then detect out of range count/rptr/wptr
| and return -1 for bad indices.
| In the callers,
|       ps2_common_post_load(ps2);
|       return 0;
| can then become simply
|       return ps2_common_post_load(ps2);

  Okay; Sent a revised patch v2.

Thank you.
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

reply via email to

[Prev in Thread] Current Thread [Next in Thread]