[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1 |
Date: |
Thu, 16 Nov 2017 16:10:22 +0000 |
On 16 November 2017 at 15:56, Michael S. Tsirkin <address@hidden> wrote:
> On Thu, Nov 16, 2017 at 03:45:34PM +0000, Daniel P. Berrange wrote:
>> On Thu, Nov 16, 2017 at 05:38:18PM +0200, Michael S. Tsirkin wrote:
>> > I think it's test: fix detection of errors from iasl
>> > I'll drop it for now.
>>
>> I think that patch is merely exposing a failure that has always
>> happened, but which we've never noticed before. So dropping that
>> patch just hides the error again, doesn't fix the error.
> We shouldn't fail test if system can't load expected files.
> This just will trip up people trying to build qemu.
If there are known-buggy iasl versions in the wild we could
consider a configure test and treat buggy-iasl like no-iasl.
thanks
-- PMM
- [Qemu-devel] [PULL 07/10] tests/acpi-test-data: update _CRS in DSDT, (continued)
- [Qemu-devel] [PULL 07/10] tests/acpi-test-data: update _CRS in DSDT, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 08/10] NUMA: Enable adding NUMA node implicitly, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 09/10] vmcoreinfo: put it in the 'misc' device category, Michael S. Tsirkin, 2017/11/15
- [Qemu-devel] [PULL 10/10] build-sys: restrict vmcoreinfo to fw_cfg+dma capable targets, Michael S. Tsirkin, 2017/11/15
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Peter Maydell, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Thomas Huth, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Michael S. Tsirkin, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Daniel P. Berrange, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Michael S. Tsirkin, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Daniel P. Berrange, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Peter Maydell, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Thomas Huth, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Michael S. Tsirkin, 2017/11/16
- Re: [Qemu-devel] [PULL 00/10] pc, pci, virtio: fixes for rc1, Michael S. Tsirkin, 2017/11/16