[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2] qapi: block-core: Clarify event
Re: [Qemu-devel] [Qemu-block] [PATCH v2] qapi: block-core: Clarify events emitted by 'block-job-cancel'
Fri, 17 Nov 2017 12:18:13 +0100
On Fri, Nov 17, 2017 at 11:49:05AM +0100, Kevin Wolf wrote:
> Am 16.11.2017 um 10:14 hat Kashyap Chamarthy geschrieben:
> > On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote:
> > > It's an interesting gotcha that I wasn't really acutely aware of myself,
> > > so having it in the doc format for API programmers who aren't
> > > necessarily digging through our source sounds like a pleasant courtesy.
> > Indeed, will do. (Just for my own clarity, did you imply: don't update
> > it in block-core.json? FWIW, my first instinct is to check the QAPI
> > documentation for such things, that's why I wrote there first :-))
> Will that be a separate patch or do you intend to send a v3?
I can send a separate one if you prefer, but I was intending to send a
v3 with both files fixed as it's just a related trivial change. Is that