[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snap

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] block/snapshot: dirty all dirty bitmaps on snapshot-switch
Date: Fri, 17 Nov 2017 13:30:59 +0100
User-agent: Mutt/1.9.1 (2017-09-22)

Am 23.10.2017 um 11:29 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Snapshot-switch actually changes active state of disk so it should
> reflect on dirty bitmaps. Otherwise next incremental backup using
> these bitmaps will be invalid.
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>

We discussed this quite a while ago, and I'm still not convinced that
this approach makes sense.

Can you give just one example of a use case where dirtying the whole
bitmap while loading a snapshot is the desired behaviour?

I think the most useful behaviour would be something where the bitmaps
themselves are snapshotted, too. But for the time being, the easiest and
safest solution might just be to error out in any snapshot operations
if any bitmaps are in use.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]