[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH for-2.11] qcow2: fix image corruption on commit with persistent snapshot
Date: Fri, 17 Nov 2017 18:19:20 +0100
User-agent: Mutt/1.9.1 (2017-09-22)

Am 17.11.2017 um 17:47 hat Eric Blake geschrieben:
> If an image contains persistent snapshots, we cannot use the
> fast path of bdrv_make_empty() to clear the image during
> qemu-img commit, because that will lose the clusters related
> to the bitmaps.
> Also leave a comment in qcow2_read_extensions to remind future
> feature additions to think about fast-path removal, since we
> just barely fixed the same bug for LUKS encryption.
> It's a pain that qemu-img has not yet been taught to manipulate,
> or even at a very minimum display, information about persistent
> bitmaps; instead, we have to use QMP commands.  It's also a
> pain that only qeury-block and x-debug-block-dirty-bitmap-sha256


> will allow bitmap introspection; but the former requires the
> node to be hooked to a block device, and the latter is experimental.
> Signed-off-by: Eric Blake <address@hidden>

Thanks, fixed the typo above and applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]