[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner var

From: Eric Blake
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment
Date: Fri, 17 Nov 2017 11:59:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 11/17/2017 07:18 AM, Cleber Rosa wrote:
> On 11/17/2017 02:19 AM, Paolo Bonzini wrote:
>> On 16/11/2017 18:38, Cleber Rosa wrote:
>>> This variables has no real use.  To avoid pretending it does, while
>>> still keeping the information, let's turn it into a comment.
>>> The format chosen is the one already being used on tests 149 and 194.
>> I would just delete it...
>> Paolo
> I'm fine with both, but I feel this is like putting info on ChangeLogs
> in the days of GIT.  Unless other people object, I'll remove them in v2.

I'm also in the 'please delete it; git history is good enough' camp.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]