[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab supp
Re: [Qemu-devel] [PATCH 02/24] sdl: remove -alt-grab and -ctrl-grab support
Fri, 17 Nov 2017 22:14:12 +0100
On Fri, Nov 17, 2017 at 11:06:12AM -0500, Programmingkid wrote:
> > With absolute pointer devices such as usb-tablet being widely used
> > mouse grabs (for relative pointing devices) should be rarely needed
> > these days. So the benefit of the options to configure the hotkey
> > modifiers for grab (and other actions) seems questionable. Which
> > is expecially true for the -ctrl-grab which isn't handled in the
> > handle_keyup() code.
> So does this mean you are against a patch that would allow the user to
> chose a key to act as a mouse ungrab key?
I don't consider it a top priority, and given there I have lots of other
things to do I most likely wouldn't implement that. But I wouldn't
object if someone comes up with a sane implementation.
What we have right now is just a big mess though, both in code and the
user interface. First, these are toplevel command line options. It
belongs to -display though. Second, it's two hard-coded names for two
hard-coded variations. So it's not like you can configure much. On top
of that the names are not exactly intuitive. And it works with SDL only.