[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/6] Net patches
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PULL 0/6] Net patches |
Date: |
Mon, 20 Nov 2017 05:39:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 20.11.2017 04:44, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PULL 0/6] Net patches
> Type: series
> Message-id: address@hidden
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> t [tag update] patchew/address@hidden -> patchew/address@hidden
> * [new tag] patchew/address@hidden -> patchew/address@hidden
> Switched to a new branch 'test'
> 6d998dcb3e hw/net/vmxnet3: Fix code to work on big endian hosts, too
> e3b7d3045b net: Transmit zero UDP checksum as 0xFFFF
> 528693e2ba MAINTAINERS: Add missing entry for eepro100 emulation
> 434d3f0987 hw/net/eepro100: Fix endianness problem on big endian hosts
> c2e0b52dd7 Revert "Add new PCI ID for i82559a"
> 3e70742c2d colo-compare: fix the dangerous assignment
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/6: colo-compare: fix the dangerous assignment...
> Checking PATCH 2/6: Revert "Add new PCI ID for i82559a"...
> Checking PATCH 3/6: hw/net/eepro100: Fix endianness problem on big endian
> hosts...
> Checking PATCH 4/6: MAINTAINERS: Add missing entry for eepro100 emulation...
> Checking PATCH 5/6: net: Transmit zero UDP checksum as 0xFFFF...
> Checking PATCH 6/6: hw/net/vmxnet3: Fix code to work on big endian hosts,
> too...
> ERROR: spaces required around that ':' (ctx:VxV)
> #237: FILE: hw/net/vmxnet3.h:232:
> + u32 msscof:14; /* MSS, checksum offset, flags */
> ^
>
> ERROR: spaces required around that ':' (ctx:VxV)
> #238: FILE: hw/net/vmxnet3.h:233:
> + u32 ext1:1;
> ^
Just for the records (again): These errors seem to be false positives
from checkpatch. I originally tried to add spaces to all changed
bitfields, but then checkpatch suddenly complains that spaces are not
allowed there...
Thomas
- [Qemu-devel] [PULL 0/6] Net patches, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 1/6] colo-compare: fix the dangerous assignment, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 2/6] Revert "Add new PCI ID for i82559a", Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 4/6] MAINTAINERS: Add missing entry for eepro100 emulation, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 5/6] net: Transmit zero UDP checksum as 0xFFFF, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 3/6] hw/net/eepro100: Fix endianness problem on big endian hosts, Jason Wang, 2017/11/19
- [Qemu-devel] [PULL 6/6] hw/net/vmxnet3: Fix code to work on big endian hosts, too, Jason Wang, 2017/11/19
- Re: [Qemu-devel] [PULL 0/6] Net patches, no-reply, 2017/11/19
- Re: [Qemu-devel] [PULL 0/6] Net patches,
Thomas Huth <=
- Re: [Qemu-devel] [PULL 0/6] Net patches, Peter Maydell, 2017/11/20