On Fri, Nov 17, 2017 at 05:03:27PM +0800, Yu Ning wrote:
On 11/17/2017 2:00, Eduardo Habkost wrote:
On Thu, Nov 16, 2017 at 07:47:44AM +0100, Stefan Weil wrote:
Am 16.11.2017 um 07:50 schrieb address@hidden:
From: Yu Ning <address@hidden>
hax-interface.h defines the interface between the HAXM kernel
module and the HAXM QEMU accelerator. The same code can be found in
the following files of the HAXM kernel module:
include/hax_interface.h
include/vcpu_state.h
core/include/vm.h
These files are now open source under the 3-clause BSD license,
whereas hax-interface.h in QEMU uses GPLv2.
Why is this a problem?
I know very little about licenses. If this is not a problem, I'm happy to
just abandon this patch.
As far as I can see, this is not a problem for the QEMU project
at all, as QEMU as a whole is GPLv2.
It would make sense to update the license if we wanted to keep
our header file in sync with some other source tree (e.g. the one
from Intel), but this doesn't seem to be the case here (yet?).
If we really care about consistency between the two
projects, shouldn't we just delete the existing file and copy the
headers from github.com/intel/haxm directly?
That's a good solution, but not feasible at the moment, because in the HAXM
kernel module, a small piece of the interface code currently resides in an
internal header (core/include/vm.h). Probably we should clean up the
interface headers on the HAXM side, and then push the change to QEMU.
This would be nice, so we wouldn't need to maintain a different
header file in QEMU. Should we open an issue at
https://github.com/intel/haxm?