[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 02/14] block/dirty-bitmap: add locked version

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] [PATCH v8 02/14] block/dirty-bitmap: add locked version of bdrv_release_dirty_bitmap
Date: Mon, 20 Nov 2017 12:30:24 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

17.11.2017 21:25, John Snow wrote:

On 11/17/2017 03:07 AM, Vladimir Sementsov-Ogievskiy wrote:
11.11.2017 01:52, John Snow wrote:
On 10/30/2017 12:32 PM, Vladimir Sementsov-Ogievskiy wrote:
It is needed to realize bdrv_dirty_bitmap_release_successor in
the following patch.

OK, but...

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
   block/dirty-bitmap.c | 25 ++++++++++++++++++++-----
   1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index 81adbeb6d4..981f99d362 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -326,13 +326,13 @@ static bool
bdrv_dirty_bitmap_has_name(BdrvDirtyBitmap *bitmap)
       return !!bdrv_dirty_bitmap_name(bitmap);
   -/* Called with BQL taken.  */
-static void bdrv_do_release_matching_dirty_bitmap(
+/* Called within bdrv_dirty_bitmap_lock..unlock */
...Add this so it will compile:
how do you compile to get an error? and what is unused?

.../src/qemu/block/dirty-bitmap.c:368:13: error:
‘bdrv_release_dirty_bitmap_locked’ defined but not used
  static void bdrv_release_dirty_bitmap_locked(BlockDriverState *bs,
cc1: all warnings being treated as errors

I commented on the wrong prototype. The ((__unused__)) attribute just
quiets this warning so it can compile without you having to refactor.

aha ok, you are right


Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]