[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.11] linux-user: Fix calculation of auxv le

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH for-2.11] linux-user: Fix calculation of auxv length
Date: Mon, 20 Nov 2017 13:38:43 +0000

On 8 November 2017 at 08:41, Richard Henderson <address@hidden> wrote:
> On 11/07/2017 07:25 PM, Peter Maydell wrote:
>> In commit 7c4ee5bcc82e643 we changed the order in which we construct
>> the AUXV, but forgot to adjust the calculation of the length. The
>> result is that we set info->auxv_len to a bogus and negative value,
>> and then later on the code in open_self_auxv() gets confused and
>> ends up presenting the guest with an empty file.
>> Since we now have to calculate the auxv length up-front as part
>> of figuring out how much we're going to put on the stack, set
>> info->auxv_len then; this allows us to assert that we put the
>> same number of entries into auxv as we pre-calculated, rather
>> than merely having a comment saying we need to do that.
>> Fixes: https://bugs.launchpad.net/qemu/+bug/1728116
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>>  linux-user/elfload.c | 11 +++++++++--
>>  1 file changed, 9 insertions(+), 2 deletions(-)
> Reviewed-by: Richard Henderson <address@hidden>

Ping! This is a for-2.11 patch with review, and rc2 is tomorrow:
Riku, are you planning a pull request?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]