[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2] build: disarm the TCG unit test trap

From: Daniel P. Berrange
Subject: [Qemu-devel] [PATCH v2] build: disarm the TCG unit test trap
Date: Tue, 21 Nov 2017 14:25:38 +0000

Developers sometimes mistakenly run 'make test' instead of 'make check'.
'make test' triggers the ancient, unmaintained tcg unit tests in
tests/tcg/Makefile which have long since ceased compiling.

Even if someone fixes the TCG tests, it makes little sense to put
them in a 'make test' target, rather they should be 'make check-tcg',
possibly wired up as a dependency of 'make check'.

In the meantime, this patch disarms the 'make test' trap by simply
deleting it so users get an immediate error. This should be enough
for them to remember to type 'make check' instead (or 'make help'
to learn). It also deletes 'make speed' which is another route
into the tcg tests.

Signed-off-by: Daniel P. Berrange <address@hidden>

Changed in v2:

 - Remove 'test' & 'speed' targets, instead of making 'test'
   a synonym for 'check'

 Makefile | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index d2e31d98af..ab0354c153 100644
--- a/Makefile
+++ b/Makefile
@@ -253,7 +253,7 @@ Makefile: ;
 configure: ;
 .PHONY: all clean cscope distclean html info install install-doc \
-       pdf txt recurse-all speed test dist msi FORCE
+       pdf txt recurse-all dist msi FORCE
 $(call set-vpath, $(SRC_PATH))
@@ -716,10 +716,6 @@ endif
        $(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
-# various test targets
-test speed: all
-       $(MAKE) -C tests/tcg $@
 .PHONY: ctags
        rm -f tags

reply via email to

[Prev in Thread] Current Thread [Next in Thread]