Re: [Qemu-devel] [PATCH v3 00/45] Windbg supporting

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v3 00/45] Windbg supporting
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d362b89cac windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex
18aff3dc37 windbg: added new api functions
2bcb5c3e4a windbg: implemented kd_api_query_memory
5ec1f614fe windbg: implemented kd_api_fill_memory
62f31d70ce windbg: implemented kd_api_search_memory
271fa73151 windbg: implemented kd_api_read_msr and kd_api_write_msr
3acac8e660 windbg: implemented kd_api_get_version
9de41ff4f4 windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory
6b29ad10e5 windbg: implemented kd_api_read_io_space and kd_api_write_io_space
c5b8c6d44a windbg: implemented kd_api_continue
dd48382a4d windbg: debug exception subscribing
f39bcbc62e windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint
09dca429d2 windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove
623796d1f2 windbg: implemented windbg_set_dr7
736fc3dd85 windbg: implemented windbg_set_dr
7fdef2c475 windbg: implemented windbg_set_sr
1a4d2aecdb windbg: implemented windbg_write_ks_regs
811bd2ada7 windbg: implemented windbg_read_ks_regs
65fbd065d8 windbg: implemented windbg_write_context
58e16be427 windbg: implemented windbg_read_context
d537b5a79b windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space
e97babd70b windbg: implemented kd_api_get_context and kd_api_set_context
9dbe11adbd windbg: kernel's structures
77b3eba622 windbg: implemented kd_api_read_virtual_memory and 
kd_api_write_virtual_memory
7aecc04a58 windbg: implemented windbg_process_manipulate_packet
2aa0acc7d1 windbg: implemented windbg_process_data_packet
2bf0bd91ec windbg: implemented windbg_process_control_packet
75c0091cb6 windbg: windbg_vm_stop
a8181bff22 windbg: generate LoadSymbolsStateChange
05f4ef3358 windbg: generate ExceptionStateChange
bd46bf1699 windbg: sized data buffer
2032fcb9f0 windbg: init DBGKD_ANY_WAIT_STATE_CHANGE
eee56f5887 windbg: handler of parsing context
a906b8b0d9 windbg: send data and control packets
7ba62b6241 windbg: parsing data stream
dfc08cb26c windbg: structures for parsing data stream
7d750760fb windbg: handler of fs/gs register
4ccf74e383 windbg: hook to wrmsr operation
696a5b890e windbg: added chardev
3dd2e38059 windbg: added WindbgState
71cde42e04 windbg: added helper features
8802776fb8 windbg: added '-windbg' option
65edc4e965 windbg: modified windbgkd.h
d2114acd58 windbg: added windbg's KD header file
8b0599de68 windbg: added empty windbgstub files

=== OUTPUT BEGIN ===
Checking PATCH 1/45: windbg: added empty windbgstub files...
ERROR: do not set execute permissions for source files
#30: FILE: include/exec/windbgstub-utils.h

ERROR: do not set execute permissions for source files
#54: FILE: include/exec/windbgstub.h

ERROR: do not set execute permissions for source files
#89: FILE: stubs/windbgstub.c

ERROR: do not set execute permissions for source files
#123: FILE: target/i386/windbgstub.c

ERROR: do not set execute permissions for source files
#141: FILE: windbgstub-utils.c

ERROR: do not set execute permissions for source files
#159: FILE: windbgstub.c

total: 6 errors, 0 warnings, 121 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/45: windbg: added windbg's KD header file...
ERROR: do not set execute permissions for source files
#14: FILE: include/exec/windbgkd.h

total: 1 errors, 0 warnings, 879 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/45: windbg: modified windbgkd.h...
Checking PATCH 4/45: windbg: added '-windbg' option...
Checking PATCH 5/45: windbg: added helper features...
Checking PATCH 6/45: windbg: added WindbgState...
Checking PATCH 7/45: windbg: added chardev...
Checking PATCH 8/45: windbg: hook to wrmsr operation...
Checking PATCH 9/45: windbg: handler of fs/gs register...
Checking PATCH 10/45: windbg: structures for parsing data stream...
Checking PATCH 11/45: windbg: parsing data stream...
Checking PATCH 12/45: windbg: send data and control packets...
Checking PATCH 13/45: windbg: handler of parsing context...
Checking PATCH 14/45: windbg: init DBGKD_ANY_WAIT_STATE_CHANGE...
Checking PATCH 15/45: windbg: sized data buffer...
Checking PATCH 16/45: windbg: generate ExceptionStateChange...
Checking PATCH 17/45: windbg: generate LoadSymbolsStateChange...
Checking PATCH 18/45: windbg: windbg_vm_stop...
Checking PATCH 19/45: windbg: implemented windbg_process_control_packet...
Checking PATCH 20/45: windbg: implemented windbg_process_data_packet...
Checking PATCH 21/45: windbg: implemented windbg_process_manipulate_packet...
Checking PATCH 22/45: windbg: implemented kd_api_read_virtual_memory and 
kd_api_write_virtual_memory...
Checking PATCH 23/45: windbg: kernel's structures...
Checking PATCH 24/45: windbg: implemented kd_api_get_context and 
kd_api_set_context...
Checking PATCH 25/45: windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space...
Checking PATCH 26/45: windbg: implemented windbg_read_context...
Checking PATCH 27/45: windbg: implemented windbg_write_context...
Checking PATCH 28/45: windbg: implemented windbg_read_ks_regs...
Checking PATCH 29/45: windbg: implemented windbg_write_ks_regs...
Checking PATCH 30/45: windbg: implemented windbg_set_sr...
Checking PATCH 31/45: windbg: implemented windbg_set_dr...
Checking PATCH 32/45: windbg: implemented windbg_set_dr7...
Checking PATCH 33/45: windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove...
Checking PATCH 34/45: windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint...
Checking PATCH 35/45: windbg: debug exception subscribing...
Checking PATCH 36/45: windbg: implemented kd_api_continue...
Checking PATCH 37/45: windbg: implemented kd_api_read_io_space and 
kd_api_write_io_space...
Checking PATCH 38/45: windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory...
Checking PATCH 39/45: windbg: implemented kd_api_get_version...
Checking PATCH 40/45: windbg: implemented kd_api_read_msr and 
kd_api_write_msr...
Checking PATCH 41/45: windbg: implemented kd_api_search_memory...
Checking PATCH 42/45: windbg: implemented kd_api_fill_memory...
Checking PATCH 43/45: windbg: implemented kd_api_query_memory...
Checking PATCH 44/45: windbg: added new api functions...
Checking PATCH 45/45: windbg: implemented kd_api_get_context_ex and 
kd_api_set_context_ex...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden