[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using s

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix qemu crash when using scsi-block
Date: Thu, 23 Nov 2017 10:18:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 23/11/2017 03:55, Deepa Srinivasan wrote:
> I agree that passing in QEMUIOVector to blk_aio_ioctl() as a holder of
> the void* buffer used in blk_aio_ioctl_entry() is unnecessary. But, as
> Kevin noted, read and write were using the QEMUIOVector in BlkRwCo.
> To avoid changes to the callers of blk_aio_ioctl(), I’ll change
> blk_aio_prwv() to take a void pointer instead of QEMUIOVector* and use a
> union to hold the buffer in BlkRwCo.

The union is unnecessary.  A QEMUIOVector* can be stored in a void* just


reply via email to

[Prev in Thread] Current Thread [Next in Thread]