[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] memory-internal.h: Remove obsolete claim that h

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] memory-internal.h: Remove obsolete claim that header is obsolete
Date: Thu, 23 Nov 2017 23:14:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 21/11/2017 17:04, Philippe Mathieu-Daudé wrote:
>> I'm not sure what you're suggesting. I definitely think the
>> s390 usage is pretty nasty but I guess it would need some
>> rework to get rid of. For everything else, it's nice
>> to have somewhere to share these things. You could argue
>> for splitting the header into two, one for 'between memory.c
>> and exec.c' and one for 'between memory.c and cputlb.c',
>> but is it worth the effort?
> Why not move memory_region_access_valid() + NotDirtyInfo in
> "exec/exec-all.h" and only use this to "share these things"?

exec/exec-all.h is for the TCG accelerator's runtime.  NotDirtyInfo and
notdirty_write_{prepare,complete} _might_ belong in there (they sit in
the middle between exec/exec-all.h and memory-internal.h), but
memory_region_access_valid certainly doesn't because it's used with KVM
as well.

In fact, memory_region_access_valid might as well be in memory.h.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]