[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] virtio: check VirtQueue Vring object is set
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] virtio: check VirtQueue Vring object is set |
|
Date: |
Fri, 24 Nov 2017 00:39:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 23/11/2017 20:01, P J P wrote:
> @@ -182,7 +182,7 @@ void virtio_queue_update_rings(VirtIODevice *vdev, int n)
> {
> VRing *vring = &vdev->vq[n].vring;
>
> - if (!vring->desc) {
> + if (!vring->desc || !vring->align) {
> /* not yet setup -> nothing to do */
> return;
> }
> @@ -1414,6 +1414,9 @@ void virtio_config_modern_writel(VirtIODevice *vdev,
>
> void virtio_queue_set_addr(VirtIODevice *vdev, int n, hwaddr addr)
> {
> + if (!vdev->vq[n].vring.num) {
> + return;
> + }
Why not check vring->num in virtio_queue_update_rings too?
Thanks,
Paolo
> vdev->vq[n].vring.desc = addr;
> virtio_queue_update_rings(vdev, n);
> }