[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] cpu: refactor cpu_address_space_init()
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] cpu: refactor cpu_address_space_init() |
Date: |
Fri, 24 Nov 2017 15:12:44 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Nov 23, 2017 at 05:06:31PM +0100, Paolo Bonzini wrote:
> On 23/11/2017 10:23, Peter Xu wrote:
> > + const char *prefix, MemoryRegion *mr)
> > {
> > CPUAddressSpace *newas;
> > + AddressSpace *as = g_new0(AddressSpace, 1);
> > +
> > + assert(mr);
> > + address_space_init(as, mr, prefix);
> >
>
> Now that address_space_init_shareable doesn't exist anymore, the
> AddressSpace could be placed directly in CPUAddressSpace instead of
> having a pointer. But the patches are already okay, that's a separate
> change.
Yes. Let me append another patch and repost. Thanks,
--
Peter Xu