[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 23/27] monitor: enable IO thread for (qmp & !mu
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [RFC v4 23/27] monitor: enable IO thread for (qmp & !mux) typed |
Date: |
Fri, 24 Nov 2017 11:01:49 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Peter Xu (address@hidden) wrote:
> Start to use dedicate IO thread for QMP monitors that are not using
> MUXed chardev.
>
> Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
I guess another way to do this would be to have a property on the
Chardev something like 'can use iothread' and clear that for Mux.
Dave
> ---
> monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/monitor.c b/monitor.c
> index b18d9d696c..5e0b8ed9c5 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -36,6 +36,7 @@
> #include "net/net.h"
> #include "net/slirp.h"
> #include "chardev/char-fe.h"
> +#include "chardev/char-mux.h"
> #include "ui/qemu-spice.h"
> #include "sysemu/numa.h"
> #include "monitor/monitor.h"
> @@ -4456,7 +4457,7 @@ void monitor_init(Chardev *chr, int flags)
> Monitor *mon = g_malloc(sizeof(*mon));
> GMainContext *context;
>
> - monitor_data_init(mon, false, false);
> + monitor_data_init(mon, false, !CHARDEV_IS_MUX(chr));
>
> qemu_chr_fe_init(&mon->chr, chr, &error_abort);
> mon->flags = flags;
> --
> 2.13.6
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [RFC v4 15/27] monitor: let monitor_{suspend|resume} thread safe, (continued)
- [Qemu-devel] [RFC v4 16/27] monitor: separate QMP parser and dispatcher, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 17/27] qmp: add new event "request-dropped", Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 18/27] monitor: send event when request queue full, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 19/27] qapi: introduce new cmd option "allow-oob", Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 20/27] qmp: support out-of-band (oob) execution, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 22/27] qmp: isolate responses into io thread, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 23/27] monitor: enable IO thread for (qmp & !mux) typed, Peter Xu, 2017/11/16
- Re: [Qemu-devel] [RFC v4 23/27] monitor: enable IO thread for (qmp & !mux) typed,
Dr. David Alan Gilbert <=
- [Qemu-devel] [RFC v4 24/27] qmp: add command "x-oob-test", Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 25/27] docs: update QMP documents for OOB commands, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 26/27] tests: qmp-test: verify command batching, Peter Xu, 2017/11/16
- [Qemu-devel] [RFC v4 27/27] tests: qmp-test: add oob test, Peter Xu, 2017/11/16