[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] thread: move detach_thread from creating thread to created thread |
|
Date: |
Mon, 27 Nov 2017 16:18:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 27/11/2017 16:08, Daniel P. Berrange wrote:
> We should just do
>
> if (mode == QEMU_THREAD_DETACHED) {
> pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
> }
>
This is true, but Zhecheng's patch (when fixed---see patchew's report)
would also fix a similar race on pthread_setname_np, so I think it's
fine to introduce qemu_thread_start.
Thanks,
Paolo