[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3

From: Andrew Baumann
Subject: Re: [Qemu-devel] [PATCH] BCM2837 and machine raspi3
Date: Mon, 27 Nov 2017 19:06:35 +0000

> From: Peter Maydell [mailto:address@hidden
> Sent: Saturday, 25 November 2017 10:05

> On 25 November 2017 at 16:43, bzt bzt <address@hidden> wrote:
> > Dear Andrew,
> >
> > A month passed, and the maintainers didn't gave a damn about raspi3
> support
> > in qemu. Any ideas?
> Sorry this patch fell through the cracks, but it looked to me
> to be in the state "patch got code review comments, waiting for
> submitter to resend a new version" (from about the point Konrad
> said "split this up, it's too big", which I agree with.)
> QEMU gets a lot of patches every day, so our code process relies
> on the submitter to prod things if what they're interested in
> seems to have been accidentally ignored:
> https://wiki.qemu.org/Contribute/SubmitAPatch#If_your_patch_seems_to_hav
> e_been_ignored
> FWIW, as far as I'm concerned Andrew pretty much is the maintainer
> as far as the raspi boards are concerned, so as far as those
> bits of code goes I'm happy to take his opinion on it.

In that case, IIRC my high-level suggestion was to either parameterise bcm2836 
to take a CPU model string, or else move the CPU creation out of bcm2836.c into 
the board file. From what I've understood thus far about pi3, it does not seem 
necessary to have a separate bcm2837 implementation. I suspect at that point 
the patch would be small enough that it didn't require further splitting.

> PS: if you send a new patch, send it as a new top level
> thread -- if you send it as a reply/followup to the
> first patch it's liable to not be noticed.

Please also CC me on the new patch as I am not very reliable at monitoring 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]