|
From: | Alberto Garcia |
Subject: | Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] block: Expect graph changes in bdrv_parent_drained_begin/end |
Date: | Wed, 29 Nov 2017 13:27:19 +0100 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 29 Nov 2017 11:25:10 AM CET, Paolo Bonzini wrote: > From: Kevin Wolf <address@hidden> > > The .drained_begin/end callbacks can (directly or indirectly via > aio_poll()) cause block nodes to be removed or the current BdrvChild to > point to a different child node. > > Use QLIST_FOREACH_SAFE() to make sure we don't access invalid > BlockDriverStates or accidentally continue iterating the parents of the > new child node instead of the node we actually came from. > > Signed-off-by: Kevin Wolf <address@hidden> > Tested-by: Jeff Cody <address@hidden> > Reviewed-by: Stefan Hajnoczi <address@hidden> > Reviewed-by: Jeff Cody <address@hidden> Reviewed-by: Alberto Garcia <address@hidden> Berto
[Prev in Thread] | Current Thread | [Next in Thread] |