[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v18 10/10] virtio-balloon: don't report free pages w

From: Wei Wang
Subject: [Qemu-devel] [PATCH v18 10/10] virtio-balloon: don't report free pages when page poisoning is enabled
Date: Wed, 29 Nov 2017 21:55:26 +0800

The guest free pages should not be discarded by the live migration thread
when page poisoning is enabled with PAGE_POISONING_NO_SANITY=n, because
skipping the transfer of such poisoned free pages will trigger false
positive when new pages are allocated and checked on the destination.
This patch skips the reporting of free pages in the above case.

Reported-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Wei Wang <address@hidden>
Cc: Michal Hocko <address@hidden>
 drivers/virtio/virtio_balloon.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 035bd3a..6ac4cff 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -652,7 +652,9 @@ static void report_free_page(struct work_struct *work)
        /* Start by sending the obtained cmd id to the host with an outbuf */
        send_one_desc(vb, vb->free_page_vq, virt_to_phys(&vb->start_cmd_id),
                      sizeof(uint32_t), false, true, false);
-       walk_free_mem_block(vb, 0, &virtio_balloon_send_free_pages);
+       if (!(page_poisoning_enabled() &&
+               walk_free_mem_block(vb, 0, &virtio_balloon_send_free_pages);
         * End by sending the stop id to the host with an outbuf. Use the
         * non-batching mode here to trigger a kick after adding the stop id.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]