[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] block: Make bdrv_drain_invoke() recursive
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] block: Make bdrv_drain_invoke() recursive |
Date: |
Tue, 5 Dec 2017 16:02:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 05/12/2017 15:54, Kevin Wolf wrote:
> }
>
> + bdrv_drain_invoke(bs, true);
> bdrv_drain_recurse(bs, true);
> }
>
> @@ -294,6 +298,7 @@ void bdrv_drained_end(BlockDriverState *bs)
> }
>
> bdrv_parent_drained_end(bs);
> + bdrv_drain_invoke(bs, false);
> bdrv_drain_recurse(bs, false);
> aio_enable_external(bdrv_get_aio_context(bs));
I think invoke should be done after recurse from bdrv_drain*end. In the
end aio_enable_external is a special kind of drain_end callback, so
bdrv_drain_invoke should go together with it.
Thanks,
Paolo