qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx()


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()
Date: Thu, 7 Dec 2017 05:08:32 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 05/12/17 14:28, Eric Blake wrote:

On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland <address@hidden>
---
  hw/net/eepro100.c | 19 +------------------
  1 file changed, 1 insertion(+), 18 deletions(-)


-            if (carry) {
-                crc = ((crc ^ POLYNOMIAL) | carry);

How does this compile after 1/5 renames POLYNOMIAL to POLYNOMIAL_BE in
net.h?

/me looks

Oh, you have a redundant definition in the .c file, which is now a dead
define.  Patch 1 should be updated to remove the duplicate definitions,
and fix code to uniformly use POLYNOMIAL_BE.

Ah yes, I can fix that up on a v3.

But overall, I like what the series is doing.

Great stuff, in that case I'll fix it up based upon all the comments and continue. It has been lying around in a local branch for months now...

BTW one thing I did notice is that sungem.c calls zlib's crc32 function directly which doesn't seem right, so I'll probably add that into the next version too. Once this has been done, switching the new net_crc32()/net_crc32_le() functions over to use a LUT or zlib or something else as the underlying implementation should be trivial.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]