[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/8] vhost: update_mem_cb implementation
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PATCH v3 5/8] vhost: update_mem_cb implementation |
Date: |
Mon, 11 Dec 2017 19:46:07 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
Add the meat of update_mem_cb; this is called for each region,
to add a region to our temporary list.
Our temporary list is in order we look to see if this
region can be merged with the current head of list.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
hw/virtio/trace-events | 2 ++
hw/virtio/vhost.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 55 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index 4a493bcd46..92fadec192 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -2,6 +2,8 @@
# hw/virtio/vhost.c
vhost_section(const char *name, int r) "%s:%d"
+vhost_update_mem_cb(const char *name, uint64_t gpa, uint64_t size, uint64_t
host) "%s: 0x%"PRIx64"+0x%"PRIx64" @ 0x%"PRIx64
+vhost_update_mem_cb_abut(const char *name, uint64_t new_size) "%s: 0x%"PRIx64
# hw/virtio/virtio.c
virtqueue_alloc_element(void *elem, size_t sz, unsigned in_num, unsigned
out_num) "elem %p size %zd in_num %u out_num %u"
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 6d720036db..646a3480c1 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -643,11 +643,63 @@ struct vhost_update_mem_tmp {
/* Called for each MRS from vhost_update_mem */
static int vhost_update_mem_cb(MemoryRegionSection *mrs, void *opaque)
{
+ struct vhost_update_mem_tmp *vtmp = opaque;
+ struct vhost_memory_region *cur_vmr;
+ bool need_add = true;
+ uint64_t mrs_size;
+ uint64_t mrs_gpa;
+ uintptr_t mrs_host;
+
if (!vhost_section(mrs)) {
return 0;
}
+ mrs_size = int128_get64(mrs->size);
+ mrs_gpa = mrs->offset_within_address_space;
+ mrs_host = (uintptr_t)memory_region_get_ram_ptr(mrs->mr) +
+ mrs->offset_within_region;
+
+ trace_vhost_update_mem_cb(mrs->mr->name, mrs_gpa, mrs_size, mrs_host);
+
+ if (vtmp->nregions) {
+ /* Since we already have at least one region, lets see if
+ * this extends it; since we're scanning in order, we only
+ * have to look at the last one, and the FlatView that calls
+ * us shouldn't have overlaps.
+ */
+ struct vhost_memory_region *prev_vmr = vtmp->regions +
+ (vtmp->nregions - 1);
+ uint64_t prev_gpa_start = prev_vmr->guest_phys_addr;
+ uint64_t prev_gpa_end = range_get_last(prev_gpa_start,
+ prev_vmr->memory_size);
+ uint64_t prev_host_start = prev_vmr->userspace_addr;
+ uint64_t prev_host_end = range_get_last(prev_host_start,
+ prev_vmr->memory_size);
+
+ if (prev_gpa_end + 1 == mrs_gpa &&
+ prev_host_end + 1 == mrs_host &&
+ (!vtmp->dev->vhost_ops->vhost_backend_can_merge ||
+ vtmp->dev->vhost_ops->vhost_backend_can_merge(vtmp->dev,
+ mrs_host, mrs_size,
+ prev_host_start, prev_vmr->memory_size))) {
+ /* The two regions abut */
+ need_add = false;
+ mrs_size = mrs_size + prev_vmr->memory_size;
+ prev_vmr->memory_size = mrs_size;
+ trace_vhost_update_mem_cb_abut(mrs->mr->name, mrs_size);
+ }
+ }
+
+ if (need_add) {
+ vtmp->nregions++;
+ vtmp->regions = g_realloc_n(vtmp->regions, vtmp->nregions,
+ sizeof(vtmp->regions[0]));
+ cur_vmr = &vtmp->regions[vtmp->nregions - 1];
+ cur_vmr->guest_phys_addr = mrs_gpa;
+ cur_vmr->memory_size = mrs_size;
+ cur_vmr->userspace_addr = mrs_host;
+ cur_vmr->flags_padding = 0;
+ }
- /* TODO */
return 0;
}
--
2.14.3
- [Qemu-devel] [PATCH v3 0/8] Rework vhost memory region updates, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 2/8] vhost: Move log_dirty check, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 3/8] vhost: Simplify ring verification checks, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 4/8] vhost: New memory update functions, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 5/8] vhost: update_mem_cb implementation,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PATCH v3 7/8] vhost: Remove old vhost_set_memory etc, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 6/8] vhost: Compare and copy updated region data into device state, Dr. David Alan Gilbert (git), 2017/12/11
- [Qemu-devel] [PATCH v3 8/8] vhost: Move mem_sections maintenance into commit/update routines, Dr. David Alan Gilbert (git), 2017/12/11